Deprecate ExprSchema functions
#15847
Open
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m09526
suggested changes
Apr 25, 2025
comphead
reviewed
Apr 26, 2025
comphead
reviewed
Apr 26, 2025
comphead
reviewed
Apr 26, 2025
|
Marking as draft as I think this PR is no longer waiting on feedback and I am trying to clear review queue. Please mark it as ready for review when it is ready for another look |
Co-authored-by: Oleks V <[email protected]>
Co-authored-by: Oleks V <[email protected]>
Co-authored-by: Oleks V <[email protected]>
timsaucer
reviewed
May 16, 2025
| @@ -961,16 +961,19 @@ impl Display for DFSchema { | |||
| /// widely used in the DataFusion codebase. | |||
| pub trait ExprSchema: std::fmt::Debug { | |||
| /// Is this column reference nullable? | |||
| #[deprecated(since = "48.0.0", note = "Use ExprSchemable::nullable")] | |||
There was a problem hiding this comment.
Shouldn't the note point the user to use field_from_column? This looks self referential.
| fn nullable(&self, col: &Column) -> Result<bool> { | ||
| Ok(self.field_from_column(col)?.is_nullable()) | ||
| } | ||
|
|
||
| /// What is the datatype of this column? | ||
| #[deprecated(since = "48.0.0", note = "Use ExprSchemable::data_type")] |
There was a problem hiding this comment.
Same comment about field_from_column
| fn data_type(&self, col: &Column) -> Result<&DataType> { | ||
| Ok(self.field_from_column(col)?.data_type()) | ||
| } | ||
|
|
||
| /// Returns the column's optional metadata. | ||
| #[deprecated(since = "48.0.0", note = "Use ExprSchemable::metadata")] |
There was a problem hiding this comment.
Same comment about field_from_column
timsaucer
changed the title
ExprSchemable functions ExprSchema functions
|
I also think the comment is pointing from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?